#267 Add command options for --timeout and --max-memory - #371
Merged
Conversation
* defaults are 120 seconds and 1000 MB * this replaces a dynamic computation based on file size entirely * this allo to control explicitly and strictly the runtime quotas and adjust them to constrained environments such as VMs. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Collaborator
|
The only thing I'm wondering about is whether it would make sense to still compute the default values dynamically, and only for constrained environments use the fixed values from the command line, if any. |
Member
Author
|
@sschuberth you have a good point but I thought this became too complicated |
Collaborator
|
Sounds reasonable! |
Member
Author
|
ok, so I am merging this and I will start a separate branch to push the rest of the fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and adjust them to constrained environments such as VMs.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com